[ 
https://issues.apache.org/jira/browse/HADOOP-19635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18010340#comment-18010340
 ] 

ASF GitHub Bot commented on HADOOP-19635:
-----------------------------------------

anmolanmol1234 commented on code in PR #7825:
URL: https://github.com/apache/hadoop/pull/7825#discussion_r2235721787


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1242,7 +1246,12 @@ public AbfsRestOperation getPathStatus(final String path,
           && isImplicitCheckRequired && isNonEmptyDirectory(path, 
tracingContext)) {
         // Implicit path found.
         // Create a marker blob at this path.
-        this.createMarkerAtPath(path, null, contextEncryptionAdapter, 
tracingContext);
+        try {

Review Comment:
   marker creation is best effort for us, we don't want to fail the actual 
operation called if marker creation fails, so only for marker creation we are 
swallowing exception and not blocking the actual call





> ABFS: [FNS Over Blob] Marker creation fail exception should not be propagated
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-19635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19635
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: hadoop-azure
>    Affects Versions: 3.4.1
>            Reporter: Anmol Asrani
>            Assignee: Anmol Asrani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.1
>
>
> Marker creation is attempted during certain operations such as {*}create{*}, 
> {*}getPathStatus{*}, {*}setPathProperties{*}, and {*}rename{*}, in order to 
> add a 0-byte file that signifies the existence of a folder at that path. 
> However, if marker creation fails, the failure should not be propagated to 
> the user.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to