abstractdog commented on PR #7827: URL: https://github.com/apache/hadoop/pull/7827#issuecomment-3135574684
> Hi @abstractdog @slfan1989, > > I ended up deleting the SecretManagerConfig file and moved the relevant code into SecretManager. This ensures that only SecretManager has access to key generation and MAC creation, reducing the risk of other components using that logic unintentionally. > > Thank you for your previous reviews and suggestions—they were very helpful in improving this PR. When you have a moment, could you kindly take another look? > > Thanks again! thanks a lot @K0K0V0K for taking care of this, looks good to me! I know not everything you’ve had to do here has been the most exciting—it is what it is, especially as long as we’re dealing with static stuff around SecretManager let me defer the final decision to hadoop folks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
