ahmarsuhail commented on code in PR #7720:
URL: https://github.com/apache/hadoop/pull/7720#discussion_r2242680859
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -128,6 +141,48 @@ public int read(byte[] buf, int off, int len) throws
IOException {
return bytesRead;
}
+ /**
+ * {@inheritDoc}
+ * Pass to {@link #readVectored(List, IntFunction, Consumer)}
+ * with the {@link VectoredReadUtils#LOG_BYTE_BUFFER_RELEASED} releaser.
+ * @param ranges the byte ranges to read.
+ * @param allocate the function to allocate ByteBuffer.
+ * @throws IOException IOE if any.
+ */
+ @Override
+ public void readVectored(List<? extends FileRange> ranges,
+ IntFunction<ByteBuffer> allocate)
throws IOException {
+ readVectored(ranges, allocate, LOG_BYTE_BUFFER_RELEASED);
+ }
+
+ /**
+ * {@inheritDoc}
+ * Pass to {@link #readVectored(List, IntFunction, Consumer)}
+ * with the {@link VectoredReadUtils#LOG_BYTE_BUFFER_RELEASED} releaser.
+ * @param ranges the byte ranges to read.
+ * @param allocate the function to allocate ByteBuffer.
+ * @throws IOException IOE if any.
+ */
+ @Override
+ public void readVectored(final List<? extends FileRange> ranges,
+ final IntFunction<ByteBuffer> allocate,
+ final Consumer<ByteBuffer> release) throws
IOException {
+ LOG.debug("AAL: Starting vectored read on path {} for ranges {} ",
getPathStr(), ranges);
+ throwIfClosed();
+
+ List<ObjectRange> objectRanges = new ArrayList<>();
+
+ for (FileRange range : ranges) {
+ CompletableFuture<ByteBuffer> result = new CompletableFuture<>();
+ ObjectRange objectRange = new ObjectRange(result, range.getOffset(),
range.getLength());
+ objectRanges.add(objectRange);
+ range.setData(result);
+ }
+
+ // AAL does not do any range coalescing, so input and combined ranges are
the same.
+ this.getS3AStreamStatistics().readVectoredOperationStarted(ranges.size(),
ranges.size());
+ inputStream.readVectored(objectRanges, allocate, release);
Review Comment:
ah no :( release isn't called right now, but will make that change and get
it released in the next version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
