ahmarsuhail commented on code in PR #7738:
URL: https://github.com/apache/hadoop/pull/7738#discussion_r2242908029
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStream.java:
##########
@@ -205,6 +209,12 @@ private OpenStreamInformation
buildOpenStreamInformation(ObjectReadParameters pa
.etag(parameters.getObjectAttributes().getETag()).build());
}
+ if(parameters.getEncryptionSecrets().getEncryptionMethod() ==
S3AEncryptionMethods.SSE_C) {
Review Comment:
On the GET, you only need it for SSE_C i think, this is what the current S3A
implementation does as well here:
https://github.com/apache/hadoop/blob/636d822682715dbc05af9483e91a9f0ee72f83b8/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java#L639
On writing you need to set it for KMS as well, so the write operation knows
what key to use. Think on the GET, the right key just gets picked up
automatically from KMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
