steveloughran commented on code in PR #7830:
URL: https://github.com/apache/hadoop/pull/7830#discussion_r2243211963
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/EncryptionSecrets.java:
##########
@@ -54,7 +56,10 @@ public class EncryptionSecrets implements Writable,
Serializable {
public static final int MAX_SECRET_LENGTH = 2048;
- private static final long serialVersionUID = 1208329045511296375L;
+ /**
+ * Change this after any change to the payload: {@value}.
+ */
+ private static final long serialVersionUID = 8834417969966697162L;
Review Comment:
IntelliJ has a helper
* java serialization: you MUST update the value if the payload the set of
serialized fields (everything non file not tagged as `transient`) changes. I
think consensus is you can generate any sufficiently random number and all is
good. Key is: change it.
* hadoop writable (which is how this stuff is actually marshalled in
delegation tokens): you implement the read/write. This means we can be adaptive
here in reading old versions too. which is what I'll do.
I don't worry about the java serialization so much as it'll only surface if
people are trying to save delegation tokens in odd ways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
