[
https://issues.apache.org/jira/browse/HADOOP-19197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18010970#comment-18010970
]
ASF GitHub Bot commented on HADOOP-19197:
-----------------------------------------
steveloughran commented on code in PR #7830:
URL: https://github.com/apache/hadoop/pull/7830#discussion_r2243211963
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/EncryptionSecrets.java:
##########
@@ -54,7 +56,10 @@ public class EncryptionSecrets implements Writable,
Serializable {
public static final int MAX_SECRET_LENGTH = 2048;
- private static final long serialVersionUID = 1208329045511296375L;
+ /**
+ * Change this after any change to the payload: {@value}.
+ */
+ private static final long serialVersionUID = 8834417969966697162L;
Review Comment:
IntelliJ has a helper
* java serialization: you MUST update the value if the payload the set of
serialized fields (everything non file not tagged as `transient`) changes. I
think consensus is you can generate any sufficiently random number and all is
good. Key is: change it.
* hadoop writable (which is how this stuff is actually marshalled in
delegation tokens): you implement the read/write. This means we can be adaptive
here in reading old versions too. which is what I'll do.
I don't worry about the java serialization so much as it'll only surface if
people are trying to save delegation tokens in odd ways
> S3A: Support AWS KMS Encryption Context
> ---------------------------------------
>
> Key: HADOOP-19197
> URL: https://issues.apache.org/jira/browse/HADOOP-19197
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Raphael Azzolini
> Assignee: Raphael Azzolini
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> S3A properties allow users to choose the AWS KMS key
> ({_}fs.s3a.encryption.key{_}) and S3 encryption algorithm to be used
> (f{_}s.s3a.encryption.algorithm{_}). In addition to the AWS KMS Key, an
> encryption context can be used as non-secret data that adds additional
> integrity and authenticity to check the encrypted data. However, there is no
> option to specify the [AWS KMS Encryption
> Context|https://docs.aws.amazon.com/kms/latest/developerguide/concepts.html#encrypt_context]
> in S3A.
> In AWS SDK v2 the encryption context in S3 requests is set by the parameter
> [ssekmsEncryptionContext.|https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/model/CreateMultipartUploadRequest.Builder.html#ssekmsEncryptionContext(java.lang.String)]
> It receives a base64-encoded UTF-8 string holding JSON with the encryption
> context key-value pairs. The value of this parameter could be set by the user
> in a new property {_}*fs.s3a.encryption.context*{_}, and be stored in the
> [EncryptionSecrets|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/EncryptionSecrets.java]
> to later be used when setting the encryption parameters in
> [RequestFactoryImpl|https://github.com/apache/hadoop/blob/f92a8ab8ae54f11946412904973eb60404dee7ff/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
