slfan1989 commented on code in PR #7841:
URL: https://github.com/apache/hadoop/pull/7841#discussion_r2246635377
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/BlockReportTestBase.java:
##########
@@ -910,7 +927,7 @@ public void run() {
startDNandWait(filePath, true);
} catch (Exception e) {
e.printStackTrace();
- Assert.fail("Failed to start BlockChecker: " + e);
+ Assertions.fail("Failed to start BlockChecker: " + e);
Review Comment:
Assertions. It would be best if they could be extracted to imports.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/InternalDataNodeTestUtils.java:
##########
@@ -172,8 +172,8 @@ public DatanodeRegistration answer(InvocationOnMock
invocation)
@Override
DatanodeProtocolClientSideTranslatorPB connectToNN(
InetSocketAddress nnAddr) throws IOException {
- Assert.assertEquals(nnSocketAddr, nnAddr);
- return namenode;
+ Assertions.assertEquals(nnSocketAddr, nnAddr);
Review Comment:
Assertions. It would be best if they could be extracted to imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
