[ https://issues.apache.org/jira/browse/HADOOP-19645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011391#comment-18011391 ]
ASF GitHub Bot commented on HADOOP-19645: ----------------------------------------- anmolanmol1234 commented on code in PR #7837: URL: https://github.com/apache/hadoop/pull/7837#discussion_r2247441472 ########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingHeaderVersion.java: ########## @@ -0,0 +1,50 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs.utils; + +public enum TracingHeaderVersion { + + V0("", 8), + V1("v1", 13); + + private final String version; + private final int fieldCount; + + TracingHeaderVersion(String version, int fieldCount) { + this.version = version; + this.fieldCount = fieldCount; + } + + @Override + public String toString() { + return version; + } + + public static TracingHeaderVersion getCurrentVersion() { + return V1; Review Comment: will this need to be updated everytime a new version is introduced ? > ABFS: [ReadAheadV2] Improve Metrics for Read Calls to identify type of read > done. > --------------------------------------------------------------------------------- > > Key: HADOOP-19645 > URL: https://issues.apache.org/jira/browse/HADOOP-19645 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.3.6, 3.4.1 > Reporter: Anuj Modi > Assignee: Anuj Modi > Priority: Major > Labels: pull-request-available > > There are a number of ways in which ABFS driver can trigger a network call to > read data. We need a way to identify what type of read call was made from > client. Plan is to add an indication for this in already present > ClientRequestId header. > Following are types of read we want to identify: > # Direct Read: Read from a given position in remote file. This will be > synchronous read > # Normal Read: Read from current seeked position where read ahead was > bypassed. This will be synchronous read. > # Prefetch Read: Read triggered from background threads filling up in memory > cache. This will be asynchronous read. > # Missed Cache Read: Read triggered after nothing was received from read > ahead. This will be synchronous read. > # Footer Read: Read triggered as part of footer read optimization. This will > be synchronous. > # Small File Read: Read triggered as a part of small file read. This will be > synchronous read. > We will add another field in the Tracing Header (Client Request Id) for each > request. We can call this field "Operation Specific Header" very similar to > how we have "Retry Header" today. As part of this we will only use it for > read operations keeping it empty for other operations. Moving ahead f we need > to publish any operation specific info, same header can be used. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org