shameersss1 commented on PR #7828:
URL: https://github.com/apache/hadoop/pull/7828#issuecomment-3146596017
> @shameersss1 Should you be adding unit tests to cover the following two
edge cases? Or those are already covered?
>
> 1. Lock acquisition failure. Important because lock acquisition could
fail in high contention.
>
> 2. Exception during locked section. Important to verify lock release
in error conditions
The locking is inconsistent with the other methods in the class which uses
try{}finally{} block to release the lock, hence i don't see any concerns here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
