anujmodi2021 commented on code in PR #7837:
URL: https://github.com/apache/hadoop/pull/7837#discussion_r2250351378
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java:
##########
@@ -77,8 +81,7 @@ public class TracingContext {
* this field shall not be set.
*/
private String primaryRequestIdForRetry;
-
- private Integer operatedBlobCount = null;
+ private Integer operatedBlobCount = 1; // Only relevant for rename-delete
over blob endpoint where it will be explicitly set.
Review Comment:
Because it was coming out as null in ClientReqId. Having a null value does
not looks good and can be prone to NPE if someone used this value anywhere.
Since this is set only in rename/delete other ops are prone to NPE.
As to why set to 1, I thought for every operation this has to be 1. I am
open to suggestions for a better default value but strongly feel null should be
avoided.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
