anujmodi2021 commented on code in PR #7837:
URL: https://github.com/apache/hadoop/pull/7837#discussion_r2251505718
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java:
##########
@@ -886,40 +928,54 @@ private void
testReadTypeInTracingContextHeaderInternal(AzureBlobFileSystem fs,
ArgumentCaptor<ContextEncryptionAdapter> captor8 =
ArgumentCaptor.forClass(ContextEncryptionAdapter.class);
ArgumentCaptor<TracingContext> captor9 =
ArgumentCaptor.forClass(TracingContext.class);
- verify(fs.getAbfsStore().getClient(), times(numOfReadCalls)).read(
+ verify(fs.getAbfsStore().getClient(), times(totalReadCalls)).read(
captor1.capture(), captor2.capture(), captor3.capture(),
captor4.capture(), captor5.capture(), captor6.capture(),
captor7.capture(), captor8.capture(), captor9.capture());
- TracingContext tracingContext = captor9.getAllValues().get(numOfReadCalls
- 1);
- verifyHeaderForReadTypeInTracingContextHeader(tracingContext, readType);
+ List<TracingContext> tracingContextList = captor9.getAllValues();
+ if (readType == PREFETCH_READ) {
+ /*
+ * For Prefetch Enabled, first read can be Normal or Missed Cache Read.
+ * Sow e will assert only for last 2 calls which should be Prefetched
Read.
+ * Since calls are asynchronous, we can not guarantee the order of calls.
+ * Therefore, we cannot assert on exact position here.
+ */
+ for (int i = tracingContextList.size() - (numOfReadCalls - 1); i <
tracingContextList.size(); i++) {
+
verifyHeaderForReadTypeInTracingContextHeader(tracingContextList.get(i),
readType, -1);
+ }
+ } else if (readType == DIRECT_READ) {
+ int expectedReadPos = ONE_MB/3;
Review Comment:
Already added in comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
