anmolanmol1234 commented on code in PR #7817: URL: https://github.com/apache/hadoop/pull/7817#discussion_r2260197782
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/KeepAliveCache.java: ########## @@ -212,45 +115,34 @@ public synchronized void close() { @VisibleForTesting void closeInternal() { - timerTask.cancel(); - timer.purge(); - while (!empty()) { - KeepAliveEntry e = pop(); - closeHttpClientConnection(e.httpClientConnection); + while (size() != 0) { + closeHttpClientConnection(removeFirst()); Review Comment: Should use the same code used in add method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org