[
https://issues.apache.org/jira/browse/HADOOP-19604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012776#comment-18012776
]
ASF GitHub Bot commented on HADOOP-19604:
-----------------------------------------
manika137 commented on code in PR #7853:
URL: https://github.com/apache/hadoop/pull/7853#discussion_r2262099471
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AzureDFSIngressHandler.java:
##########
@@ -179,7 +179,10 @@ protected synchronized AbfsRestOperation remoteFlush(final
long offset,
tracingContextFlush.setIngressHandler(DFS_FLUSH);
tracingContextFlush.setPosition(String.valueOf(offset));
}
- String fullBlobMd5 = computeFullBlobMd5();
+ String fullBlobMd5 = null;
+ if (getClient().isFullBlobChecksumValidationEnabled()) {
Review Comment:
Since the check getClient().isFullBlobChecksumValidationEnabled() is common
in both DFS, Blob ingress handlers- we can add it as a common method in the
abstract class itself
> ABFS: Fix WASB ABFS compatibility issues
> ----------------------------------------
>
> Key: HADOOP-19604
> URL: https://issues.apache.org/jira/browse/HADOOP-19604
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.1
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.1
>
>
> Fix WASB ABFS compatibility issues. Fix issues such as:-
> # BlockId computation to be consistent across clients for PutBlock and
> PutBlockList
> # Restrict url encoding of certain json metadata during setXAttr calls.
> # Maintain the md5 hash of whole block to validate data integrity during
> flush.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
