anujmodi2021 commented on PR #7674: URL: https://github.com/apache/hadoop/pull/7674#issuecomment-3170289646
> @anujmodi2021 I've fixed all the issues you pointed out. Could you please help review this PR again? Much appreciated! > > After rebasing the code on the latest trunk, the unit tests have been comprehensively upgraded to use JUnit 5. The key improvements and adjustments are as follows: > > > Standardized Use of @timeout Annotation > > All test methods using @timeout now explicitly specify the unit parameter to preserve the original time unit (milliseconds via TimeUnit.MILLISECONDS), ensuring consistent behavior without altering existing logic. > > > Assertion Parameter Order Corrections > > Issues caused by incorrect parameter ordering in assertEquals assertions during migration have been manually reviewed and corrected to ensure accurate test logic and prevent false negatives. > > > Replacement of Assume Statements > > Legacy org.junit.Assume statements have been replaced with JUnit 5's org.junit.jupiter.api.Assumptions.assumeTrue, bringing assumption-based tests into alignment with the JUnit 5 framework. > > > Parameterized Test Structure Optimization > > Introduced the new JUnit 5 annotation @ParameterizedClass to refactor parameterized tests. This preserves the original structure as much as possible while significantly improving readability and maintainability. > > > Removal of JUnit 4 Dependency > > The hadoop-azure module has fully removed its dependency on JUnit 4. All upgraded tests now compile and run successfully under JUnit 5 alone. Thanks a lot for taking in my suggestions and fixes. Your efforts are truely commendable. Will go through the recent changes and run a test suite for sanity check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
