slfan1989 commented on code in PR #7864:
URL: https://github.com/apache/hadoop/pull/7864#discussion_r2265536992


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRecovery.java:
##########
@@ -258,21 +256,30 @@ public Set<Long> getValidTxIds() {
   }
   
   /** Test an empty edit log */
-  @Test(timeout=180000)
-  public void testEmptyLog() throws IOException {
+  @MethodSource("data")
+  @ParameterizedTest

Review Comment:
   We can optimize this part using the @ParameterizedClass annotation, as 
referenced in #7814.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to