[
https://issues.apache.org/jira/browse/HADOOP-19609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013885#comment-18013885
]
ASF GitHub Bot commented on HADOOP-19609:
-----------------------------------------
manika137 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2276186992
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsConnectionManager.java:
##########
@@ -201,7 +279,69 @@ public void shutdown() {
private void logDebug(String message, Object... args) {
if (LOG.isDebugEnabled()) {
- LOG.debug(message, args);
+ logDebug(message, args);
+ }
+ }
+
+ /**
+ * Caches extra connections in the {@link KeepAliveCache} to warm it up.
+ * This method is called during initialization and when the cache is empty.
+ *
+ * @param route the HTTP route for which connections are created
+ * @param numberOfConnections the number of connections to create
+ */
+ private void cacheExtraConnection(final HttpRoute route, final int
numberOfConnections) {
+ if (!isCaching.getAndSet(true)) {
+ long start = System.currentTimeMillis();
+ // Only one thread allowed at a time
+ ExecutorService executorService =
Executors.newFixedThreadPool(Math.min(numberOfConnections, 5));
Review Comment:
Or maybe we can cancel all futures while we are awaiting termination after
1sec (after line 313) to avoid hanging threads
> ABFS: Apache Client Connection Pool Relook
> ------------------------------------------
>
> Key: HADOOP-19609
> URL: https://issues.apache.org/jira/browse/HADOOP-19609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Manish Bhatt
> Assignee: Manish Bhatt
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
