stoty commented on PR #7434: URL: https://github.com/apache/hadoop/pull/7434#issuecomment-3191598426
> Hi @stoty, do you have a plan to continue this work? Yes, but I don't have the time right now. I hope to be able to return to this in about a month. > > I briefly went through the change, if I understand correctly, this PR mainly consists of 2 parts: > > 1. route UGI doAs to `Subject.callAs` for newer JDKs, and fallback to original API for older JDKs > 2. migrate Thread / ThreadPool invocations to HadoopThread / HadoopThreadPool, to restore the capability of Subject propagation Yes, that's correct. I think that HadoopThreadPool is not really needed, as the executors don't really preserve subjects either, and we probably already have code to set the subject where needed. > > The part 1 change is relatively light, Trino's forked Hadoop project only changes this part. Can we change this part first to allow the downstream project that uses the Hadoop client to work with the new JDK? The Thread changes are required for Java 22+, while the doAs() stuff is only fully removed in 23+ (it can be turned back on by enabling SecurityManager before that). I don't know how much of the MR / HDFS client would work on JDK22+ without the Thread changes though, there are a lot of changes, I don't remember how much of them are used on the client side without digging back in the code. The Subject changes should be enough to support JDK21 without securityManager. The two changes are orthogonal, so the order doesn't really matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
