bhattmanish98 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2280767506
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/KeepAliveCache.java:
##########
@@ -199,10 +102,10 @@ private void closeHttpClientConnection(final
HttpClientConnection hc) {
}
/**
- * Close all connections in cache and cancel the eviction timer.
+ * Close all connections in cache.
*/
@Override
- public synchronized void close() {
+ public void close() {
Review Comment:
Not required, the below implementation will guarantee that only one thread
will call closeInternal method
boolean closed = isClosed.getAndSet(true);
if (closed) {
return;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
