anmolanmol1234 commented on code in PR #7868:
URL: https://github.com/apache/hadoop/pull/7868#discussion_r2281359848
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFilesystemAcl.java:
##########
@@ -238,41 +276,46 @@ public void testModifyAclEntriesStickyBit() throws
Exception {
fs.modifyAclEntries(path, aclSpec);
AclStatus s = fs.getAclStatus(path);
AclEntry[] returned = s.getEntries().toArray(new AclEntry[0]);
- assertArrayEquals(new AclEntry[]{aclEntry(ACCESS, USER, FOO, READ_EXECUTE),
- aclEntry(ACCESS, GROUP, READ_EXECUTE), aclEntry(DEFAULT, USER, ALL),
- aclEntry(DEFAULT, USER, FOO, READ_EXECUTE), aclEntry(DEFAULT, GROUP,
READ_EXECUTE),
- aclEntry(DEFAULT, MASK, READ_EXECUTE), aclEntry(DEFAULT, OTHER, NONE)},
+ assertArrayEquals(new AclEntry[]{
+ aclEntry(ACCESS, USER, FOO, READ_EXECUTE),
+ aclEntry(ACCESS, GROUP, READ_EXECUTE),
+ aclEntry(DEFAULT, USER, ALL),
+ aclEntry(DEFAULT, USER, FOO, READ_EXECUTE),
+ aclEntry(DEFAULT, GROUP, READ_EXECUTE),
+ aclEntry(DEFAULT, MASK, READ_EXECUTE),
+ aclEntry(DEFAULT, OTHER, NONE)
+ },
returned);
assertPermission(fs, (short) 01750);
}
@Test
public void testModifyAclEntriesPathNotFound() throws Exception {
- Assertions.assertThrows(FileNotFoundException.class, () -> {
- final AzureBlobFileSystem fs = this.getFileSystem();
- assumeTrue(getIsNamespaceEnabled(fs));
- path = new Path(testRoot, UUID.randomUUID().toString());
- List<AclEntry> aclSpec = Lists.newArrayList(
- aclEntry(ACCESS, USER, ALL),
- aclEntry(ACCESS, USER, FOO, ALL),
- aclEntry(ACCESS, GROUP, READ_EXECUTE),
- aclEntry(ACCESS, OTHER, NONE));
- fs.modifyAclEntries(path, aclSpec);
- });
+ assumeTrue(getIsNamespaceEnabled(getFileSystem()));
+ Assertions.assertThrows(FileNotFoundException.class, () -> {
+ final AzureBlobFileSystem fs = this.getFileSystem();
+ path = new Path(testRoot, UUID.randomUUID().toString());
+ List<AclEntry> aclSpec = Lists.newArrayList(
+ aclEntry(ACCESS, USER, ALL),
+ aclEntry(ACCESS, USER, FOO, ALL),
+ aclEntry(ACCESS, GROUP, READ_EXECUTE),
+ aclEntry(ACCESS, OTHER, NONE));
+ fs.modifyAclEntries(path, aclSpec);
+ });
}
@Test
public void testModifyAclEntriesDefaultOnFile() throws Exception {
- Assertions.assertThrows(Exception.class, () -> {
- final AzureBlobFileSystem fs = this.getFileSystem();
- assumeTrue(getIsNamespaceEnabled(fs));
- path = new Path(testRoot, UUID.randomUUID().toString());
- fs.create(path).close();
- fs.setPermission(path, FsPermission.createImmutable((short) RW_R));
- List<AclEntry> aclSpec = Lists.newArrayList(
- aclEntry(DEFAULT, USER, FOO, ALL));
- fs.modifyAclEntries(path, aclSpec);
- });
+ Assertions.assertThrows(Exception.class, () -> {
+ final AzureBlobFileSystem fs = this.getFileSystem();
Review Comment:
same as above, only space changes can be reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
