cnauroth opened a new pull request, #7885:
URL: https://github.com/apache/hadoop/pull/7885

   ### Description of PR
   
   First, make sure test libraries like jersey-test-framework-provider-jetty 
are limited to scope test.
   
   Then, update other modules that didn't know they were getting their test 
dependencies through YARN to depend on test libraries explicitly.
   
   ### How was this patch tested?
   
   I used `mvn dependency:tree` to check that the test dependencies were gone 
after these changes. Before the changes, we had this in the final distro after 
`mvn clean package -Pdist -Dtar -DskipTests -DskipShade`:
   
   ```
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/mapreduce/lib/mockito-junit-jupiter-4.11.0.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/lib/junit-jupiter-5.11.0.jar
   /tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-4.13.2.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-engine-5.13.3.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-platform-commons-1.13.3.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-platform-engine-1.13.3.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-params-5.13.3.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/junit-jupiter-api-5.13.3.jar
   /tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/yarn/lib/hamcrest-3.0.jar
   
/tmp/distro/hadoop-3.5.0-SNAPSHOT/share/hadoop/tools/lib/hamcrest-core-1.3.jar
   ```
   
   After these changes, everything is gone except for the stuff in 
`hadoop/tools/lib`. This is apparently intentional dependencies of 
`hadoop-tools/hadoop-compat-bench`, but it won't creep into the classpath for 
dependent projects like Parquet.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to