cnauroth commented on code in PR #7877:
URL: https://github.com/apache/hadoop/pull/7877#discussion_r2284051350
##########
hadoop-tools/hadoop-gcp/pom.xml:
##########
@@ -351,7 +351,6 @@
</shadedPattern>
</relocation>
</relocations>
- <shadedArtifactAttached>true</shadedArtifactAttached>
Review Comment:
We have two options:
1. shadedArtifactAttached=true means a separate shaded jar artifact will be
attached to the build. Clients can depend on it by specifying
`<classifier>shaded</classifier>` in the dependency declaration.
2. shadedArtifactAttached=false (the default, hence removed in this patch)
means the shaded jar completely replaces the published artifact. I think this
is what we want for hadoop-gcp, given the tight coupling to specific shaded
versions of things like Guava and gRPC. There wouldn't be much value in the
non-shaded artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
