pan3793 commented on PR #7892: URL: https://github.com/apache/hadoop/pull/7892#issuecomment-3235716054
The change LGTM. @stoty thank you for such great works! The current diff is huge, my only suggestion is to extract the `SubjectInheritingThread`, `Daemon`, and related test suites to a dedicated PR after you complete the integration tests. This also benefits future explorers of the Hadoop codebase, I have had many bad experiences in finding the essential changes in a large patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
