[
https://issues.apache.org/jira/browse/HADOOP-19609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017426#comment-18017426
]
ASF GitHub Bot commented on HADOOP-19609:
-----------------------------------------
anmolanmol1234 commented on code in PR #7817:
URL: https://github.com/apache/hadoop/pull/7817#discussion_r2313772047
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsConnectionManager.java:
##########
@@ -70,39 +69,44 @@ class AbfsConnectionManager implements
HttpClientConnectionManager {
private final HttpClientConnectionOperator connectionOperator;
/**
- * Number of connections to be created during cache refresh.
+ * AbfsConfiguration instance to get configuration values.
*/
- private final int cacheRefreshConnections;
+ private final AbfsConfiguration abfsConfiguration;
/**
- * Connection timeout for establishing a new connection.
+ * Atomic boolean to ensure only one thread can trigger cache refresh at a
time.
*/
- private final int connectionTimeout;
-
- private final AtomicBoolean isCaching = new AtomicBoolean(false);
+ private final AtomicBoolean isCacheRefreshInProgress = new AtomicBoolean(
+ false);
+ /**
+ * Lock object for synchronizing connection retrieval and caching.
+ */
private final Object connectionLock = new Object();
+ /**
+ * The base host for which connections are managed.
+ */
private HttpHost baseHost;
AbfsConnectionManager(Registry<ConnectionSocketFactory>
socketFactoryRegistry,
AbfsHttpClientConnectionFactory connectionFactory, KeepAliveCache kac,
final AbfsConfiguration abfsConfiguration, final URL baseUrl) {
this.httpConnectionFactory = connectionFactory;
- this.connectionTimeout = abfsConfiguration.getHttpConnectionTimeout();
this.kac = kac;
this.connectionOperator = new DefaultHttpClientConnectionOperator(
socketFactoryRegistry, null, null);
- if (abfsConfiguration.getCacheWarmupConnections() > 0) {
+ this.abfsConfiguration = abfsConfiguration;
+ if (abfsConfiguration.getApacheCacheWarmupCount() > 0) {
// Warm up the cache with connections.
logDebug("Warming up the KeepAliveCache with {} connections",
Review Comment:
Directly using LOG.Debug should be better instead of a recursive method just
for debug logging
> ABFS: Apache Client Connection Pool Relook
> ------------------------------------------
>
> Key: HADOOP-19609
> URL: https://issues.apache.org/jira/browse/HADOOP-19609
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.1
> Reporter: Manish Bhatt
> Assignee: Manish Bhatt
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
