[
https://issues.apache.org/jira/browse/HADOOP-19478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020091#comment-18020091
]
ASF GitHub Bot commented on HADOOP-19478:
-----------------------------------------
github-actions[bot] commented on PR #7463:
URL: https://github.com/apache/hadoop/pull/7463#issuecomment-3289002205
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> S3A: pull out new configuration load/probes under S3AStore
> ----------------------------------------------------------
>
> Key: HADOOP-19478
> URL: https://issues.apache.org/jira/browse/HADOOP-19478
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> S3AFS i's too full of switches; it is why initialize() is so big, and there
> are lots and lots of fields to record the values.
> Many of these need to go down into S3AStoreImpl, but replicating the same
> design just pushes the mess down.
> Proposed: a child service StoreConfigurationService, which reads in the
> config during serviceInit(), and set the state in there, from where it can be
> probed.
> I am initially doing this purely for new configuration flags for the
> conditional write feature
> * moving other flags in there would be separate work
> * new boolean config options should go in here
> * we also need to think about integers, units of scale and durations.
> Ideally, we should the annotations and reflection code from ABFS and
> org.apache.hadoop.fs.azurebfs.contracts.annotations.ConfigurationValidationAnnotations,
> * copy it into common
> * adding duration and size attributes
> * move reflection code from AbfsConfiguration#AbfsConfiguration into there
> too,
> * use in s3a
> * migrate abfs to the moved code
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
