brumi1024 commented on code in PR #7979:
URL: https://github.com/apache/hadoop/pull/7979#discussion_r2359223851
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java:
##########
@@ -549,25 +550,50 @@ public HttpServer2 build() throws IOException {
}
for (URI ep : endpoints) {
- final ServerConnector connector;
+ //
+ // To enable dual-stack or IPv6 support, use InetAddress
+ // .getAllByName(hostname) to resolve the IP addresses of a host.
+ // When the system property java.net.preferIPv4Stack is set to true,
+ // only IPv4 addresses are returned, and any IPv6 addresses are
+ // ignored, so no extra check is needed to exclude IPv6.
+ // When java.net.preferIPv4Stack is false, both IPv4 and IPv6
+ // addresses may be returned, and any IPv6 addresses will also be
+ // added as connectors.
+ // To disable IPv4, you need to configure the OS at the system level.
+ //
+ InetAddress[] addresses = InetAddress.getAllByName(ep.getHost());
+ server = addConnectors(
+ ep, addresses, server, httpConfig, backlogSize, idleTimeout);
+ }
+ server.loadListeners();
+ return server;
+ }
+
+ @VisibleForTesting
+ HttpServer2 addConnectors(
+ URI ep, InetAddress[] addresses, HttpServer2 server,
+ HttpConfiguration httpConfig, int backlogSize, int idleTimeout){
+ for (InetAddress addr : addresses) {
+ ServerConnector connector;
String scheme = ep.getScheme();
if (HTTP_SCHEME.equals(scheme)) {
- connector = createHttpChannelConnector(server.webServer,
- httpConfig);
+ connector = createHttpChannelConnector(
+ server.webServer, httpConfig);
} else if (HTTPS_SCHEME.equals(scheme)) {
- connector = createHttpsChannelConnector(server.webServer,
- httpConfig);
+ connector = createHttpsChannelConnector(
+ server.webServer, httpConfig);
} else {
throw new HadoopIllegalArgumentException(
"unknown scheme for endpoint:" + ep);
}
- connector.setHost(ep.getHost());
+ LOG.info("Adding connector to WebServer for address {}",
Review Comment:
Do we need info level for this? Debug might be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
