steveloughran commented on code in PR #7942:
URL: https://github.com/apache/hadoop/pull/7942#discussion_r2348701684
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -594,13 +595,28 @@ private static <T> T getField(Object target, Class<T>
fieldType,
public void testConfOptionPropagationToFS() throws Exception {
Configuration config = new Configuration();
String testFSName = config.getTrimmed(TEST_FS_S3A_NAME, "");
- String bucket = new URI(testFSName).getHost();
+ URI uri = new URI(testFSName);
+ String bucket = uri.getHost();
+ if (bucket == null) {
+ bucket = uri.getAuthority();
+ }
setBucketOption(config, bucket, "propagation", "propagated");
fs = S3ATestUtils.createTestFileSystem(config);
Configuration updated = fs.getConf();
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test
+ public void testBucketNameWithDotAndNumber() throws Exception {
+ Configuration config = new Configuration();
+ Path path = new Path("s3a://test-bucket-v1.1");
+ try (FileSystem fs = path.getFileSystem(config)) {
+ assertThat(fs instanceof S3AFileSystem)
Review Comment:
use whatever assertj assertion is about instanceof, so you get a better
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
