zeekling commented on code in PR #6845:
URL: https://github.com/apache/hadoop/pull/6845#discussion_r2369180733
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java:
##########
@@ -783,15 +783,11 @@ public void removeVeryOldStoppedContainersFromCache() {
break;
}
if (!context.getContainers().containsKey(cid)) {
- ApplicationId appId =
- cid.getApplicationAttemptId().getApplicationId();
- if (isApplicationStopped(appId)) {
Review Comment:
I carefully reviewed the code again and there should be no problem of
aggregation failure.
By the way.
Aggregate logs of containers that completed more than 30 minutes (or
longer) to onto HDFS in advance, rather than waiting for the job to completed.
Is this implementation better than the current one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
