anmolanmol1234 commented on code in PR #7967:
URL: https://github.com/apache/hadoop/pull/7967#discussion_r2381728892
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsApacheHttpClient.java:
##########
@@ -73,18 +80,21 @@ static boolean usable() {
}
AbfsApacheHttpClient(DelegatingSSLSocketFactory delegatingSSLSocketFactory,
- final AbfsConfiguration abfsConfiguration, final KeepAliveCache
keepAliveCache,
- URL baseUrl) {
+ final AbfsConfiguration abfsConfiguration,
+ final KeepAliveCache keepAliveCache,
+ URL baseUrl,
+ final boolean isCacheWarmupNeeded) {
final AbfsConnectionManager connMgr = new AbfsConnectionManager(
createSocketFactoryRegistry(
new SSLConnectionSocketFactory(delegatingSSLSocketFactory,
getDefaultHostnameVerifier())),
new AbfsHttpClientConnectionFactory(), keepAliveCache,
- abfsConfiguration, baseUrl);
+ abfsConfiguration, baseUrl, isCacheWarmupNeeded);
final HttpClientBuilder builder = HttpClients.custom();
builder.setConnectionManager(connMgr)
.setRequestExecutor(
- new
AbfsManagedHttpRequestExecutor(abfsConfiguration.getHttpReadTimeout()))
+ new AbfsManagedHttpRequestExecutor(
Review Comment:
As we were discussing last time, if we keep it to read timeout the 100
continue timeout would become 30 seconds, this should be another config for 100
continue timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
