[
https://issues.apache.org/jira/browse/HADOOP-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028497#comment-18028497
]
ASF GitHub Bot commented on HADOOP-18935:
-----------------------------------------
github-actions[bot] commented on PR #6177:
URL: https://github.com/apache/hadoop/pull/6177#issuecomment-3383635837
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> coalesce AWS S3 client proxy settings
> -------------------------------------
>
> Key: HADOOP-18935
> URL: https://issues.apache.org/jira/browse/HADOOP-18935
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> all the code to build up proxy settings for the two clients is nearly
> identical.
> * coalesce into on method to load all the options, another to apply them to
> the different bullders
> * extend TestS3AProxy to test async client too
> * test for invalid options, rather than just the good paths.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
