szetszwo commented on code in PR #7983:
URL: https://github.com/apache/hadoop/pull/7983#discussion_r2417678062
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2673,7 +2673,7 @@ private RpcSaslProto buildSaslNegotiateResponse()
// accelerate token negotiation by sending initial challenge
// in the negotiation response
if (enabledAuthMethods.contains(AuthMethod.TOKEN)
- &&
SaslMechanismFactory.isDefaultMechanism(AuthMethod.TOKEN.getMechanismName())) {
+ &&
SaslMechanismFactory.isDigestMechanism(AuthMethod.TOKEN.getMechanismName())) {
Review Comment:
DIGEST-MD5 uses MD5 and some other old algorithms. We are working with a
new DIGEST based mechanism for replacing the old algorithms.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslMechanismFactory.java:
##########
@@ -65,5 +65,13 @@ public static boolean isDefaultMechanism(String
saslMechanism) {
return HADOOP_SECURITY_SASL_MECHANISM_DEFAULT.equals(saslMechanism);
}
+ public static boolean isDigestMechanism(String saslMechanism) {
+ return saslMechanism.startsWith("DIGEST-");
Review Comment:
In some cases, conf objects are unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
