K0K0V0K commented on code in PR #8033:
URL: https://github.com/apache/hadoop/pull/8033#discussion_r2441860945
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/helper/AppInfoJsonVerifications.java:
##########
@@ -88,8 +87,8 @@ public static void verify(JSONObject info, RMApp app) throws
JSONException {
"clusterUsagePerc doesn't match");
assertEquals(1, info.getInt("runningContainers"),
"numContainers doesn't match");
- assertNotNull(info.get("preemptedResourceSecondsMap"),
- "preemptedResourceSecondsMap should not be null");
+ assertTrue(info.isNull("preemptedResourceSecondsMap"),
+ "preemptedResourceSecondsMap should be null, cause it is empty");
Review Comment:
The preemptedResourceSecondsMap if empty
- Jersey1 -> { }
- Jersey2 + Jettison -> ""
- Jersey2 + Moxy -> not present
I was not able to reproduce the exact same behaviour here as it was in
Jersey1
https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html#Cluster_Scheduler_API
I checked the doc and could not find this property so i was like try to live
with this change and see what we get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]