[
https://issues.apache.org/jira/browse/HADOOP-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HADOOP-8244:
--------------------------------
Target Version/s: 2.0.1-alpha (was: 0.24.0)
Committed to branch-2 as well.
> Improve comments on ByteBufferReadable.read
> -------------------------------------------
>
> Key: HADOOP-8244
> URL: https://issues.apache.org/jira/browse/HADOOP-8244
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Fix For: 0.24.0
>
> Attachments: HADOOP-8244.0.patch, HADOOP-8244.1.patch
>
>
> There are a couple of ways in which the comment on ByteBufferReadable.read
> can be improved. Since this is a public-facing API with potentially many
> implementations, it's worth taking the time to get it right.
> * We should describe what can become of the byte buffer state in the case of
> an exception (is the limit changed? where's the position?). For the
> DFSInputStream implementation, position and limit are unchanged if there is
> an error, but I don't think that's the right think to mandate for all
> implementations.
> * We should mention explicitly that 0-byte reads are legitimate - this is
> particularly important in light of HDFS-3110 which detects support for direct
> reads by issuing a 0-byte read from libhdfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
