mukund-thakur commented on code in PR #7923:
URL: https://github.com/apache/hadoop/pull/7923#discussion_r2475244946
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AInputStreamRetry.java:
##########
@@ -76,7 +79,7 @@ public class TestS3AInputStreamRetry extends
AbstractS3AMockTest {
@Test
public void testInputStreamReadRetryForException() throws IOException {
- S3AInputStream s3AInputStream =
getMockedS3AInputStream(failingInputStreamCallbacks(
+ ObjectInputStream s3AInputStream =
getMockedInputStream(failingInputStreamCallbacks(
Review Comment:
I think because of the ObjectInputStreamFactory
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AInputStreamRetry.java:
##########
@@ -76,7 +79,7 @@ public class TestS3AInputStreamRetry extends
AbstractS3AMockTest {
@Test
public void testInputStreamReadRetryForException() throws IOException {
- S3AInputStream s3AInputStream =
getMockedS3AInputStream(failingInputStreamCallbacks(
+ ObjectInputStream s3AInputStream =
getMockedInputStream(failingInputStreamCallbacks(
Review Comment:
Why these changes required? Moving S3AInputStream to ObjectInputStream.
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/streams/AnalyticsStreamFactory.java:
##########
@@ -74,7 +77,7 @@ public void bind(final FactoryBindingParameters
factoryBindingParameters) throws
public ObjectInputStream readObject(final ObjectReadParameters parameters)
throws IOException {
return new AnalyticsStream(
parameters,
- getOrCreateS3SeekableInputStreamFactory());
+ getOrCreateS3SeekableInputStreamFactory(),
retryPolicy.getAnalyticsRetryStrategy());
Review Comment:
Only RetryStrategy is used as that is part of the analyticsaccelerator
library. Why do we need a new class AnalyticsStreamRetryPolicy ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
