[ 
https://issues.apache.org/jira/browse/HADOOP-18547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18033999#comment-18033999
 ] 

ASF GitHub Bot commented on HADOOP-18547:
-----------------------------------------

github-actions[bot] commented on PR #5177:
URL: https://github.com/apache/hadoop/pull/5177#issuecomment-3465487727

   We're closing this stale PR because it has been open for 100 days with no 
activity. This isn't a judgement on the merit of the PR in any way. It's just a 
way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working 
on it, please feel free to re-open it and ask for a committer to remove the 
stale tag and review again.
   Thanks all for your contribution.




> Check if config value is not empty string in 
> AbfsConfiguration.getMandatoryPasswordString()
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-18547
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18547
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/azure
>    Affects Versions: 3.3.4
>            Reporter: Pranav Saxena
>            Assignee: Pranav Saxena
>            Priority: Minor
>              Labels: pull-request-available
>
> The method `getMandatoryPasswordString` is called in 
> `AbfsConfiguration.getTokenProvider()' to check if following configs are 
> non-null (diff keys applicable for different implementation of 
> AccessTokenProvider):
> 1. fs.azure.account.oauth2.client.endpoint: in ClientCredsTokenProvider
> 2. fs.azure.account.oauth2.client.id: in ClientCredsTokenProvider, 
> MsiTokenProvider, RefreshTokenBasedTokenProvider
> 3. fs.azure.account.oauth2.client.secret: in ClientCredsTokenProvider
> 4. fs.azure.account.oauth2.client.endpoint: in UserPasswordTokenProvider
> 5. fs.azure.account.oauth2.user.name: in UserPasswordTokenProvider
> 6. fs.azure.account.oauth2.user.password: in  UserPasswordTokenProvider
> 7. fs.azure.account.oauth2.msi.tenant: in MsiTokenProvider
> 8. fs.azure.account.oauth2.refresh.token: in RefreshTokenBasedTokenProvider
> Right now, this method checks if its non-null and not non-empty. This task 
> needs to add check on non-empty config values.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to