[
https://issues.apache.org/jira/browse/HADOOP-19737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18037680#comment-18037680
]
ASF GitHub Bot commented on HADOOP-19737:
-----------------------------------------
manika137 commented on code in PR #8056:
URL: https://github.com/apache/hadoop/pull/8056#discussion_r2517799307
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsCountersImpl.java:
##########
@@ -267,6 +298,22 @@ public AbfsReadFooterMetrics getAbfsReadFooterMetrics() {
return abfsReadFooterMetrics != null ? abfsReadFooterMetrics : null;
}
+ /**
+ * Returns the write thread pool metrics instance, or {@code null} if
uninitialized.
+ */
+ @Override
+ public AbfsWriteThreadPoolMetrics getAbfsWriteThreadPoolMetrics() {
+ return abfsWriteThreadPoolMetrics != null ? abfsWriteThreadPoolMetrics :
null;
Review Comment:
we can have it as- return abfsWriteThreadPoolMetrics;
Same for getAbfsReadThreadPoolMetrics() below
> ABFS: Add metrics to identify improvements with read and write aggressiveness
> -----------------------------------------------------------------------------
>
> Key: HADOOP-19737
> URL: https://issues.apache.org/jira/browse/HADOOP-19737
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.5.0, 3.4.2
> Reporter: Anmol Asrani
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Introduces new performance metrics in the ABFS driver to monitor and evaluate
> the effectiveness of read and write aggressiveness tuning. These metrics help
> in understanding how thread pool behavior, CPU utilization, and heap
> availability impact overall I/O throughput and latency. By capturing detailed
> statistics such as active thread count, pool size, and system resource
> utilization, this enhancement enables data-driven analysis of optimizations
> made to improve ABFS read and write performance under varying workloads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
