[ 
https://issues.apache.org/jira/browse/HADOOP-8509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294600#comment-13294600
 ] 

Hadoop QA commented on HADOOP-8509:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532007/HADOOP-8509.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test 
files.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1118//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1118//console

This message is automatically generated.
                
> JarFinder duplicate entry: META-INF/MANIFEST.MF exception
> ---------------------------------------------------------
>
>                 Key: HADOOP-8509
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8509
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.1
>            Reporter: Matteo Bertozzi
>            Assignee: Alejandro Abdelnur
>            Priority: Minor
>         Attachments: HADOOP-8509.patch
>
>
> Calling JarFinder.getJar() throws an exception if user has a 
> "META-INF/MANIFEST.MF" in the same directory of the .class specified.
> Jarfinder.getJar() call createJar() that always create a new Manifest and 
> then add all the files contained in the .class directory.
> To reproduce the problem in a simple way you can create a SimpleClass.java in 
> the same directory create a META-INF/MANIFEST.MF and then call 
> JarFinder.getJar(SimpleClass.class)
> {code}
> >> Caused by: java.util.zip.ZipException: duplicate entry: 
> >> META-INF/MANIFEST.MF
> >> at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:175)
> >> at java.util.jar.JarOutputStream.putNextEntry(JarOutputStream.java:92)
> >> at org.apache.hadoop.util.JarFinder.zipDir(JarFinder.java:66)
> >> at org.apache.hadoop.util.JarFinder.zipDir(JarFinder.java:62)
> >> at org.apache.hadoop.util.JarFinder.zipDir(JarFinder.java:44)
> >> at org.apache.hadoop.util.JarFinder.createJar(JarFinder.java:93)
> >> at org.apache.hadoop.util.JarFinder.getJar(JarFinder.java:134)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to