steveloughran commented on code in PR #8096:
URL: https://github.com/apache/hadoop/pull/8096#discussion_r2547422984
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##########
@@ -474,6 +476,7 @@ public synchronized void startInternal() throws Exception {
}
@Test
+ @Timeout(value=60, unit = TimeUnit.SECONDS, threadMode = SEPARATE_THREAD)
Review Comment:
interesting...I don't see that `threadMode` option in the junit5 version my
IDE is bringing up.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##########
@@ -610,7 +613,7 @@ protected void serviceStart() throws Exception {
}
@Test
- @Timeout(value = 9000)
+ @Timeout(value = 9000) // FIXME that's more than two hours
Review Comment:
I thought maybe this was just 9000 millis with a new default, but no, the
old timeout was 900000 mills, so now its just in a different unit.
I think the value here is to ensure that it never hangs the build forever,
its just a very big one. Looking at the history of that line, YARN-4927
multiplied the timeout up from 90 seconds, so it was probably just "a number
which made the failures go away".
I'd propose 10 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
