zhtttylz commented on PR #8053: URL: https://github.com/apache/hadoop/pull/8053#issuecomment-3584005522
> a lot of the java changes are just removing trailing spaces. Is this needed? I knowe it's not ideal to have these, but it makes for a bigger patch and cherrypicking harder. I treat them like out-of-order imports: something I leave alone except when editing the specific lines. > > spotify doesn't complain about these lines, does it? @steveloughran Thanks for the review — your point about keeping the patch small for easier cherry-picks makes sense. I’ve dropped the trailing-whitespace cleanup and introduced pattern-level filters for the new 4.9.7 rules so we reduce noise while still surfacing real issues. The `CI: trigger SpotBugs (no-op)` commit is only there to force SpotBugs to run in pre-commit (CI skips SpotBugs when there are no `.java` changes). Once the new configuration is validated, I’ll drop that no-op commit so it doesn’t end up in the final patch. With the current revision, the pre-commit SpotBugs summary (PR-8053/10 at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8053/10/consoleText) reports `0 new` findings and only fixed issues across the modules, for example: <details> <summary>SpotBugs patch summary from PR-8053/9</summary> ``` hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 448 fixed = 0 total (was 448) hadoop-hdfs-project/hadoop-hdfs-client generated 0 new + 0 unchanged - 2801 fixed = 0 total (was 2801) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 0 new + 1 unchanged - 1298 fixed = 1 total (was 1299) ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
