bhattmanish98 commented on code in PR #8051:
URL: https://github.com/apache/hadoop/pull/8051#discussion_r2568503378
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -1240,9 +1240,11 @@ public int getNumLeaseThreads() {
}
public boolean getCreateRemoteFileSystemDuringInitialization() {
- // we do not support creating the filesystem when AuthType is SAS
+ // we do not support creating the filesystem when AuthType is SAS or
UserboundSASWithOAuth
return this.createRemoteFileSystemDuringInitialization
- && this.getAuthType(this.accountName) != AuthType.SAS;
+ && this.getAuthType(this.accountName) != AuthType.SAS
Review Comment:
We have used this statement at multiple places to check if authtype is SAS
or UserBoundSAS, wouldn't it be better if we can have a method which returns
true if AuthType is SAS or UserBoundSAS else false.
##########
hadoop-tools/hadoop-azure/src/site/markdown/index.md:
##########
@@ -416,7 +432,7 @@ the key names are slightly different here.
</property>
```
-### <a name="oauth-user-and-passwd"></a> OAuth 2.0: Username and Password
+#### <a name="oauth-user-and-passwd"></a> Username and Password
Review Comment:
What is the need for this change?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java:
##########
@@ -1415,7 +1417,7 @@ public boolean shouldTrackLatency() {
public AccessTokenProvider getTokenProvider() throws
TokenAccessProviderException {
AuthType authType = getEnum(FS_AZURE_ACCOUNT_AUTH_TYPE_PROPERTY_NAME,
AuthType.SharedKey);
- if (authType == AuthType.OAuth) {
+ if (authType == AuthType.OAuth || authType ==
AuthType.UserboundSASWithOAuth) {
Review Comment:
same as above
##########
hadoop-tools/hadoop-azure/src/site/markdown/index.md:
##########
@@ -549,7 +565,7 @@ The Azure Portal/CLI is used to create the service identity.
</property>
```
-### <a name="workload-identity"></a> Azure Workload Identity
+#### <a name="workload-identity"></a> Azure Workload Identity
Review Comment:
Not needed
##########
hadoop-tools/hadoop-azure/src/site/markdown/index.md:
##########
@@ -501,7 +517,7 @@ With an existing Oauth 2.0 token, make a request to the
Active Directory endpoin
</property>
```
-### <a name="managed-identity"></a> Azure Managed Identity
+#### <a name="managed-identity"></a> Azure Managed Identity
Review Comment:
This change is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
