[ 
https://issues.apache.org/jira/browse/HADOOP-19731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041416#comment-18041416
 ] 

ASF GitHub Bot commented on HADOOP-19731:
-----------------------------------------

slfan1989 commented on code in PR #8053:
URL: https://github.com/apache/hadoop/pull/8053#discussion_r2572711473


##########
hadoop-cloud-storage-project/hadoop-huaweicloud/src/test/java/org/apache/hadoop/fs/obs/OBSContract.java:
##########
@@ -25,6 +25,7 @@
 /**
  * The contract of OBS: only enabled if the test bucket is provided.
  */
+// CI: trigger SpotBugs (no-op)

Review Comment:
   Do we need this change?



##########
hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/KMSBenchmark.java:
##########
@@ -614,4 +615,4 @@ public void setConf(Configuration conf) {
   public Configuration getConf() {
     return config;
   }
-}
\ No newline at end of file
+}

Review Comment:
   Should this change be avoided as well?





> Fix SpotBugs warnings introduced after SpotBugs version upgrade.
> ----------------------------------------------------------------
>
>                 Key: HADOOP-19731
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19731
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, hdfs, mapreduce, yarn
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> Following the upgrade to SpotBugs {*}4.9.7{*}, several new warnings have 
> emerged.
> We plan to address these warnings to improve code safety and maintain 
> compatibility with the updated analysis rules.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to