[
https://issues.apache.org/jira/browse/HADOOP-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396954#comment-13396954
]
Colin Patrick McCabe commented on HADOOP-8362:
----------------------------------------------
Hi Madhukara,
The patch looks pretty good. Just one small criticism: you should put the
braces on the same line as the 'if' or 'else' statement.
See http://wiki.apache.org/hadoop/CodeReviewChecklist for details-- basically,
we try to follow Sun's coding conventions, except with 2-space indentation
instead of 4.
(See http://java.sun.com/docs/codeconv/)
> Improve exception message when Configuration.set() is called with a null key
> or value
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8362
> URL: https://issues.apache.org/jira/browse/HADOOP-8362
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 2.0.0-alpha
> Reporter: Todd Lipcon
> Assignee: madhukara phatak
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-8362-1.patch, HADOOP-8362-2.patch,
> HADOOP-8362-3.patch, HADOOP-8362-4.patch, HADOOP-8362-5.patch,
> HADOOP-8362-6.patch, HADOOP-8362.patch
>
>
> Currently, calling Configuration.set(...) with a null value results in a
> NullPointerException within Properties.setProperty. We should check for null
> key/value and throw a better exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
