anmolanmol1234 commented on code in PR #8135: URL: https://github.com/apache/hadoop/pull/8135#discussion_r2624064878
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/JvmIdProvider.java: ########## @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs; + +import java.util.Random; + +/** + * Provides a JVM-scoped identifier. + * + * <p>The identifier is generated once when the class is loaded and remains + * constant for the lifetime of the JVM. It is derived using a combination of + * the current system time and random entropy to reduce the likelihood of + * collisions across JVM instances.</p> + * + * <p>The identifier is intended for lightweight JVM-level identification, + * such as tagging metrics or log entries. It provides best-effort uniqueness + * and is not guaranteed to be globally unique.</p> + * + * <p>This class is utility-only and cannot be instantiated.</p> + */ +public final class JvmIdProvider { Review Comment: This ID is unique per JVM, hence the name. Should I change it to JvmUniqueIdProvider ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
