anujmodi2021 commented on code in PR #8141:
URL: https://github.com/apache/hadoop/pull/8141#discussion_r2642468945
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##########
Review Comment:
I know this is not a part of change here but since we are doing code cleanup
here, I feel we should keep these constants in some constant file only like
`InternalConstants` or `MetricsConstants`.
This file mainly contains constants used in configuration.
Starting from `ZERO` to `SCALE_DIRECTION_NO_ACTION_NEEDED`
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java:
##########
@@ -42,19 +42,6 @@ public final class FileSystemConfigurations {
* Number of bytes in a gigabyte.
*/
public static final long BYTES_PER_GIGABYTE = 1024L * 1024 * 1024;
- /**
Review Comment:
There are a few constants in AbfsHttpConstants file that also need to be
removed.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/enums/AbfsWriteResourceUtilizationMetricsEnum.java:
##########
@@ -1,107 +0,0 @@
-/**
Review Comment:
Sine there is only one resource utilization metric left. Do we need the base
class?
Can we simply have one stand alone class called `ResourceUtilizationMetrics`
instead of saying read/write?
Also anyway we are monitoring JVM resources here, so single metric is
sufficient IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
