anmolanmol1234 commented on code in PR #8137:
URL: https://github.com/apache/hadoop/pull/8137#discussion_r2647826443
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBackoffMetrics.java:
##########
@@ -240,25 +251,24 @@ private String getPrecisionMetrics(AbfsBackoffMetricsEnum
metricName,
private void getRetryMetrics(StringBuilder metricBuilder) {
for (RetryValue retryCount : RETRY_LIST) {
long totalRequests = getMetricValue(TOTAL_REQUESTS, retryCount);
- metricBuilder.append(REQUEST_COUNT)
- .append(retryCount.getValue())
- .append(REQUESTS)
- .append(getMetricValue(NUMBER_OF_REQUESTS_SUCCEEDED,
retryCount));
+ if (getMetricValue(NUMBER_OF_REQUESTS_SUCCEEDED, retryCount) > 0) {
+ metricBuilder.append(REQUEST_COUNT)
+ .append(retryCount.getValue())
+ .append(REQUESTS)
+ .append(getMetricValue(NUMBER_OF_REQUESTS_SUCCEEDED, retryCount));
+ }
if (totalRequests > 0) {
metricBuilder.append(MIN_MAX_AVERAGE)
- .append(retryCount.getValue())
- .append(REQUESTS)
- .append(getPrecisionMetrics(MIN_BACK_OFF, retryCount,
THOUSAND))
- .append(SECONDS)
- .append(getPrecisionMetrics(MAX_BACK_OFF, retryCount,
THOUSAND))
- .append(SECONDS)
- .append(getPrecisionMetrics(TOTAL_BACK_OFF, retryCount,
totalRequests * THOUSAND))
- .append(SECONDS);
- } else {
- metricBuilder.append(MIN_MAX_AVERAGE)
Review Comment:
Why have we removed the MMA ones ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
