zabetak commented on code in PR #8148:
URL: https://github.com/apache/hadoop/pull/8148#discussion_r2655650905
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationDeprecation.java:
##########
@@ -465,4 +472,30 @@ public void testGetPropertyBeforeDeprecetionsAreSet()
throws Exception {
"Property should be accessible through new key");
}
+ @Test
+ public void testNoDeprecationsByDefault() throws Exception {
+ // Force initialization to make sure deprecations are recorded for later
calls to isDeprecated.
+ new Configuration();
Review Comment:
The test looks good although it can't find all deprecated properties (e.g.,
`io.bytes.per.checksum`) cause the respective config classes are not loaded. I
logged HADOOP-19769 which may be a more complete solution to avoid deprecated
props in config files. Obviously, this PR is already good enough and we don't
need to strictly wait for HADOOP-19769. If there is interest about HADOOP-19769
let me know and I will try to finalize the POC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
