[ 
https://issues.apache.org/jira/browse/HADOOP-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400552#comment-13400552
 ] 

Daryn Sharp commented on HADOOP-8523:
-------------------------------------

I'd suggest keeping this patch minimal and creating another jira for enhanced 
option handling.
                
> test-patch.sh doesn't validate patches before building
> ------------------------------------------------------
>
>                 Key: HADOOP-8523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8523
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.3, 2.0.1-alpha
>            Reporter: Jack Dintruff
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-8523.patch, Hadoop-8523.patch, Hadoop-8523.patch
>
>
> When running test-patch.sh with an invalid patch (not formatted properly) or 
> one that doesn't compile, the script spends a lot of time building Hadoop 
> before checking to see if the patch is invalid.  It would help devs if it 
> checked first just in case we run test-patch.sh with a bad patch file. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to