[ 
https://issues.apache.org/jira/browse/HADOOP-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402196#comment-13402196
 ] 

Harsh J commented on HADOOP-8525:
---------------------------------

Overall this looks pretty good!

One comment regarding completeness: I noticed Configuration being a Writable. 
I've not really seen a use of Configuration being used as Writable, but perhaps 
the readFields and write methods need to be updated too, without breaking 
compatibility? Or we may document that serialization via Writable will not 
include sources of configs.

Other than this, +1.
                
> Provide Improved Traceability for Configuration
> -----------------------------------------------
>
>                 Key: HADOOP-8525
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8525
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>            Priority: Trivial
>         Attachments: HADOOP-8525.txt
>
>
> Configuration provides basic traceability to see where a config setting came 
> from, but once the configuration is written out that information is written 
> to a comment in the XML and then lost the next time the configuration is read 
> back in.  It would really be great to be able to store a complete history of 
> where the config came from in the XML, so that it can then be retrieved later 
> for debugging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to