pan3793 commented on code in PR #8182:
URL: https://github.com/apache/hadoop/pull/8182#discussion_r2745818581
##########
hadoop-project/pom.xml:
##########
@@ -2823,7 +2830,8 @@
</activation>
<properties>
<javac.version>17</javac.version>
- <maven.compiler.release>${javac.version}</maven.compiler.release>
Review Comment:
I think we want to keep this, so that we can use a higher version of JDK to
build Hadoop, but produce Java 17 compatible bytecode. If this fails on some
modules, can we just disable it on these specific modules?
BTW, the activation condition of `jdk17+` profile is already true, we can
remove it and move the content to the top level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]