[
https://issues.apache.org/jira/browse/HADOOP-19798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18055512#comment-18055512
]
ASF GitHub Bot commented on HADOOP-19798:
-----------------------------------------
steveloughran commented on code in PR #8221:
URL: https://github.com/apache/hadoop/pull/8221#discussion_r2747672835
##########
BUILDING.txt:
##########
@@ -583,7 +583,7 @@ Requirements:
* Windows 10
* JDK 17
-* Maven 3.3 or later (maven.apache.org)
+* Maven 3.9.11 or later (maven.apache.org, optional if using mvnw.cmd)
Review Comment:
same
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -0,0 +1,4 @@
+wrapperVersion=3.3.4
Review Comment:
add an apache header
##########
.mvn/wrapper/MavenWrapperDownloader.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.Authenticator;
+import java.net.PasswordAuthentication;
+import java.net.URI;
+import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardCopyOption;
+import java.util.concurrent.ThreadLocalRandom;
+
+public final class MavenWrapperDownloader {
Review Comment:
nit: move to hadoop normal indentation.
Assuming it came from another project, say where it came from
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -0,0 +1,4 @@
+wrapperVersion=3.3.4
+distributionType=source
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.11/apache-maven-3.9.11-bin.zip
+wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.4/maven-wrapper-3.3.4.jar
Review Comment:
add sha 256 sum in wrapperSha256Sum. The scripts both check it and I don't
want unverified binaries being downloaded & executed
##########
BUILDING.txt:
##########
@@ -5,7 +5,7 @@ Requirements:
* Unix System
* JDK 17
-* Maven 3.3 or later
+* Maven 3.9.11 or later (optional if using ./mvnw)
Review Comment:
say "a compatible version is automatically downloaded if..."
> Add Maven Wrapper
> -----------------
>
> Key: HADOOP-19798
> URL: https://issues.apache.org/jira/browse/HADOOP-19798
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.0
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
