cnauroth commented on code in PR #8226:
URL: https://github.com/apache/hadoop/pull/8226#discussion_r2760206020
##########
hadoop-cloud-storage-project/hadoop-cloud-storage-dist/pom.xml:
##########
@@ -152,51 +152,39 @@ mvn package -Pdist -DskipTests -Dtar
-Dmaven.javadoc.skip=true \
<configuration>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-assemblies</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>dist</id>
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <appendAssemblyId>false</appendAssemblyId>
+ <attach>false</attach>
+ <finalName>${project.artifactId}-${project.version}</finalName>
+ <descriptorRefs>
+ <descriptorRef>hadoop-cloud-storage</descriptorRef>
+ </descriptorRefs>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
<profiles>
- <!-- distribution profile builds the artifacts. -->
- <profile>
- <id>dist</id>
Review Comment:
I remember over in #7980 I asked for this to be guarded behind `-Pdist`:
https://github.com/apache/hadoop/pull/7980#discussion_r2446383325
Did this not work correctly? Will we have to build hadoop-cloud-storage-dist
for all builds now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
